]> git.baikalelectronics.ru Git - kernel.git/commit
drm: amd: amdgpu: ACPI: Add comment about ACPI_FADT_LOW_POWER_S0
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 24 Aug 2022 17:32:21 +0000 (19:32 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 25 Aug 2022 17:35:18 +0000 (13:35 -0400)
commita9a0a31eba1a07f3614f57b6d607656240e5ddad
treee7248c40bb6d7a6c92e37cda48df8e589385f53e
parent4e6c9f5cbf3da98fe0511c8a3ad01c0ae19a7d78
drm: amd: amdgpu: ACPI: Add comment about ACPI_FADT_LOW_POWER_S0

According to the ACPI specification [1], the ACPI_FADT_LOW_POWER_S0
flag merely means that it is better to use low-power S0 idle on the
given platform than S3 (provided that the latter is supported) and it
doesn't preclude using either of them (which of them will be used
depends on the choices made by user space).

However, on some systems that flag is used to indicate whether or not
to enable special firmware mechanics allowing the system to save more
energy when suspended to idle.  If that flag is unset, doing so is
generally risky.

Accordingly, add a comment to explain the ACPI_FADT_LOW_POWER_S0 check
in amdgpu_acpi_is_s0ix_active(), the purpose of which is otherwise
somewhat unclear.

Link: https://uefi.org/specs/ACPI/6.4/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#fixed-acpi-description-table-fadt
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c