]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net: fujitsu: fix a potential NULL pointer dereference"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:41 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:30:29 +0000 (17:30 +0200)
commita87ab09e585341dea9659727773c84e076e99537
treed8e971a683b8bcd5c51404fa1097068067a1c7b9
parenta54466056e12795a8f86bf7b61b65bc4bc4ede6f
Revert "net: fujitsu: fix a potential NULL pointer dereference"

This reverts commit be05a2028da304dc4bed72d930045c104141cd26.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original change does not change any behavior as the caller of this
function onlyu checks for "== -1" as an error condition so this error is
not handled properly.  Remove this change and it will be fixed up
properly in a later commit.

Cc: Kangjie Lu <kjlu@umn.edu>
Cc: David S. Miller <davem@davemloft.net>
Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
Link: https://lore.kernel.org/r/20210503115736.2104747-15-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/fujitsu/fmvj18x_cs.c