]> git.baikalelectronics.ru Git - kernel.git/commit
net: sched: do not requeue a NULL skb
authorLars Persson <lars.persson@axis.com>
Tue, 12 Apr 2016 06:45:52 +0000 (08:45 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 14 Apr 2016 05:28:51 +0000 (01:28 -0400)
commita803c2a25cf5dba12e2d471f37426eeef29a94a8
tree24b9dbc71e8bb88416b659a25f843ef85a81403f
parent71ddff2ab396a5e6dd311746b2b1fde88d0ae09e
net: sched: do not requeue a NULL skb

A failure in validate_xmit_skb_list() triggered an unconditional call
to dev_requeue_skb with skb=NULL. This slowly grows the queue
discipline's qlen count until all traffic through the queue stops.

We take the optimistic approach and continue running the queue after a
failure since it is unknown if later packets also will fail in the
validate path.

Fixes: ef3c95e57306 ("qdisc: validate skb without holding lock")
Signed-off-by: Lars Persson <larper@axis.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_generic.c