]> git.baikalelectronics.ru Git - kernel.git/commit
s390/ap: fix status returned by ap_qact()
authorHalil Pasic <pasic@linux.ibm.com>
Wed, 8 Feb 2023 23:00:24 +0000 (00:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:02 +0000 (09:33 +0100)
commita7edceb41d99cc32f054f30734158d77861e2cb5
tree822e3458397d9219c924382a3aaff3eb2a168790
parent2da364ba82891cc571d17f5818eb9c9c77e97c4b
s390/ap: fix status returned by ap_qact()

[ Upstream commit 3a05021c511345e15548af6694ee1beb892563bc ]

Since commit 7475c796bb02 ("s390/ap: rework assembler functions to use
unions for in/out register variables") the  function ap_qact() tries to
grab the status from the wrong part of the register. Thus we always end
up with zeros. Which is wrong, among others, because we detect failures
via status.response_code.

Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
Reported-by: Harald Freudenberger <freude@linux.ibm.com>
Fixes: 7475c796bb02 ("s390/ap: rework assembler functions to use unions for in/out register variables")
Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/s390/include/asm/ap.h