]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: at803x: stop switching phy delay config needlessly
authorAndré Draszik <git@andred.net>
Fri, 9 Aug 2019 11:20:25 +0000 (12:20 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Aug 2019 21:02:29 +0000 (14:02 -0700)
commita7b4062a543982b98b3a3b4d7c422126add48939
tree2ff5404adc12634df5f94caffc691d52fe75aacc
parent05a54a6230bd877516dd72d6726fbb9785c50338
net: phy: at803x: stop switching phy delay config needlessly

This driver does a funny dance disabling and re-enabling
RX and/or TX delays. In any of the RGMII-ID modes, it first
disables the delays, just to re-enable them again right
away. This looks like a needless exercise.

Just enable the respective delays when in any of the
relevant 'id' modes, and disable them otherwise.

Also, remove comments which don't add anything that can't be
seen by looking at the code.

Signed-off-by: André Draszik <git@andred.net>
CC: Andrew Lunn <andrew@lunn.ch>
CC: Florian Fainelli <f.fainelli@gmail.com>
CC: Heiner Kallweit <hkallweit1@gmail.com>
CC: "David S. Miller" <davem@davemloft.net>
CC: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/at803x.c