]> git.baikalelectronics.ru Git - kernel.git/commit
x86/mpx: Do not set ->vm_ops on MPX VMAs
authorKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Mon, 20 Jul 2015 21:29:58 +0000 (14:29 -0700)
committerIngo Molnar <mingo@kernel.org>
Tue, 21 Jul 2015 05:57:16 +0000 (07:57 +0200)
commita7af5372961e0034e86f19d695eb1c97e9628b17
treea8491044d74dcae56dbe68d6674c6f3475a20cd9
parent0d7278ab1db56b5a157619f1efa41732dcfed298
x86/mpx: Do not set ->vm_ops on MPX VMAs

MPX setups private anonymous mapping, but uses vma->vm_ops too.
This can confuse core VM, as it relies on vm->vm_ops to
distinguish file VMAs from anonymous.

As result we will get SIGBUS, because handle_pte_fault() thinks
it's file VMA without vm_ops->fault and it doesn't know how to
handle the situation properly.

Let's fix that by not setting ->vm_ops.

We don't really need ->vm_ops here: MPX VMA can be detected with
VM_MPX flag. And vma_merge() will not merge MPX VMA with non-MPX
VMA, because ->vm_flags won't match.

The only thing left is name of VMA. I'm not sure if it's part of
ABI, or we can just drop it. The patch keep it by providing
arch_vma_name() on x86.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: <stable@vger.kernel.org> # Fixes: 29b1e9da (mm: avoid setting up anonymous pages into file mapping)
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dave@sr71.net
Link: http://lkml.kernel.org/r/20150720212958.305CC3E9@viggo.jf.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/mm/mmap.c
arch/x86/mm/mpx.c