]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: cadence: fix reference leak when pm_runtime_get_sync fails
authorQinglang Miao <miaoqinglang@huawei.com>
Tue, 1 Dec 2020 09:31:17 +0000 (17:31 +0800)
committerWolfram Sang <wsa@kernel.org>
Wed, 14 Apr 2021 07:49:03 +0000 (09:49 +0200)
commita79de0f48cf8c4cb208a2631755f38d5bab2c980
tree82e72040a7b534808e006d426bfc62b91f80cda1
parent12162418a1ecbc069ac170fdd4f0b90cc22591e9
i2c: cadence: fix reference leak when pm_runtime_get_sync fails

The PM reference count is not expected to be incremented on
return in functions cdns_i2c_master_xfer and cdns_reg_slave.

However, pm_runtime_get_sync will increment pm usage counter
even failed. Forgetting to putting operation will result in a
reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: 423cdab85bfb ("i2c: cadence: Move to sensible power management")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-cadence.c