]> git.baikalelectronics.ru Git - kernel.git/commit
ixgbe: fix double clean of Tx descriptors with xdp
authorIlya Maximets <i.maximets@samsung.com>
Thu, 22 Aug 2019 17:12:37 +0000 (20:12 +0300)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 11 Sep 2019 16:42:18 +0000 (09:42 -0700)
commita73983e0b1ea0506f666e20e73de6e41d2633ccd
tree70dd59cc8d9434aa453eda4a14a1a142e24b39ba
parent28466d9618518d2d5df3810143dc3678bddde9bd
ixgbe: fix double clean of Tx descriptors with xdp

Tx code doesn't clear the descriptors' status after cleaning.
So, if the budget is larger than number of used elems in a ring, some
descriptors will be accounted twice and xsk_umem_complete_tx will move
prod_tail far beyond the prod_head breaking the completion queue ring.

Fix that by limiting the number of descriptors to clean by the number
of used descriptors in the Tx ring.

'ixgbe_clean_xdp_tx_irq()' function refactored to look more like
'ixgbe_xsk_clean_tx_ring()' since we're allowed to directly use
'next_to_clean' and 'next_to_use' indexes.

CC: stable@vger.kernel.org
Fixes: cde8e919da8d ("ixgbe: add AF_XDP zero-copy Tx support")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Tested-by: William Tu <u9012063@gmail.com>
Tested-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c