]> git.baikalelectronics.ru Git - kernel.git/commit
soundwire: qcom: remove duplicate reset control get
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Sun, 14 Aug 2022 12:38:00 +0000 (13:38 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 23 Aug 2022 15:57:50 +0000 (21:27 +0530)
commita7308a810e93817ad46e8365dcf0a355fe5d902a
tree63a25b0e46921ae9422e4224bee7de168e90ba7a
parent3d7dcb2c5450a57f60c448f42be48fdfe456bfdf
soundwire: qcom: remove duplicate reset control get

Looks like adding clock gate flag patch forgot to remove the old code that
gets reset control.

This causes below crash on platforms that do not need reset.

[   15.653501]  reset_control_reset+0x124/0x170
[   15.653508]  qcom_swrm_init+0x50/0x1a0
[   15.653514]  qcom_swrm_probe+0x320/0x668
[   15.653519]  platform_probe+0x68/0xe0
[   15.653529]  really_probe+0xbc/0x2a8
[   15.653535]  __driver_probe_device+0x7c/0xe8
[   15.653541]  driver_probe_device+0x40/0x110
[   15.653547]  __device_attach_driver+0x98/0xd0
[   15.653553]  bus_for_each_drv+0x68/0xd0
[   15.653559]  __device_attach+0xf4/0x188
[   15.653565]  device_initial_probe+0x14/0x20

Fix this by removing old code.

Reported-by: Amit Pundir <amit.pundir@linaro.org>
Fixes: fb59dad21d0e ("soundwire: qcom: Add flag for software clock gating check")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Tested-by: Amit Pundir <amit.pundir@linaro.org>
Link: https://lore.kernel.org/r/20220814123800.31200-1-srinivas.kandagatla@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/qcom.c