]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: qcom: Fix pipe clock imbalance
authorJohan Hovold <johan+linaro@kernel.org>
Fri, 1 Apr 2022 13:33:51 +0000 (15:33 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 24 May 2022 21:39:51 +0000 (16:39 -0500)
commita71a40191f7f63558a96b7b38a915f33b0eb207d
tree2032ac2d735ad13348fb1ee08fc705774f80d53c
parentd0ede55be868ead9b0843492fad7d7d07cbe3505
PCI: qcom: Fix pipe clock imbalance

Fix a clock imbalance introduced by 8f9487ddf47c ("PCI: qcom: Add support
for SDM845 PCIe controller"), which enables the pipe clock both in init()
and in post_init() but only disables in post_deinit().

Note that the pipe clock was also never disabled in the init() error
paths and that enabling the clock before powering up the PHY looks
questionable.

Link: https://lore.kernel.org/r/20220401133351.10113-1-johan+linaro@kernel.org
Fixes: 8f9487ddf47c ("PCI: qcom: Add support for SDM845 PCIe controller")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: stable@vger.kernel.org # 5.6
drivers/pci/controller/dwc/pcie-qcom.c