]> git.baikalelectronics.ru Git - kernel.git/commit
RISC-V: Don't allow write+exec only page mapping request in mmap
authorYash Shah <yash.shah@sifive.com>
Tue, 16 Jun 2020 14:03:06 +0000 (19:33 +0530)
committerPalmer Dabbelt <palmerdabbelt@google.com>
Fri, 19 Jun 2020 00:28:53 +0000 (17:28 -0700)
commita70a1c2e3e58f28c67ee34698a2de8cef6359a68
treee53115d8f412b9e77e9519de3f5a3d3050c00501
parente8773d53bd3103e6f74f3bb6900d640c14650a12
RISC-V: Don't allow write+exec only page mapping request in mmap

As per the table 4.4 of version "20190608-Priv-MSU-Ratified" of the
RISC-V instruction set manual[0], the PTE permission bit combination of
"write+exec only" is reserved for future use. Hence, don't allow such
mapping request in mmap call.

An issue is been reported by David Abdurachmanov, that while running
stress-ng with "sysbadaddr" argument, RCU stalls are observed on RISC-V
specific kernel.

This issue arises when the stress-sysbadaddr request for pages with
"write+exec only" permission bits and then passes the address obtain
from this mmap call to various system call. For the riscv kernel, the
mmap call should fail for this particular combination of permission bits
since it's not valid.

[0]: http://dabbelt.com/~palmer/keep/riscv-isa-manual/riscv-privileged-20190608-1.pdf

Signed-off-by: Yash Shah <yash.shah@sifive.com>
Reported-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
[Palmer: Refer to the latest ISA specification at the only link I could
find, and update the terminology.]
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
arch/riscv/kernel/sys_riscv.c