]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "driver core: Annotate dev_err_probe() with __must_check"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Sep 2020 07:37:40 +0000 (09:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Sep 2020 07:37:40 +0000 (09:37 +0200)
commita6ff311c4f9eced97c6a0529fe0fe25e4f636881
treea56bcd0125dd6fb6a1a67b278b29fae7d48ddac5
parentadf3cdaa054c6476d634a7a4eb20ab056cc6c742
Revert "driver core: Annotate dev_err_probe() with __must_check"

This reverts commit bb506e64e24be8f31ffb25b4946fa6e1661d691f as it's
already starting to cause build warnings in linux-next for things that
are "obviously correct".

It's up to driver authors do "do the right thing" here with this
function, and if they don't want to call it as the last line of a
function, that's up to them, otherwise code that looks like:
ret = dev_err_probe(..., ret, ...);
does look really "odd".

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
Fixes: bb506e64e24b ("driver core: Annotate dev_err_probe() with __must_check")
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/device.h