]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: lpfc: don't dereference localport before it has been null checked
authorColin Ian King <colin.king@canonical.com>
Fri, 22 Dec 2017 00:28:52 +0000 (00:28 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 4 Jan 2018 03:52:43 +0000 (22:52 -0500)
commita6c25deeb21cd113db5a5d669b1c4f5344693e87
tree095be66c7adf0d3995f8d02bba9547e642156446
parente05ab0f6fb0dd6868b1659b13b95213c19b65669
scsi: lpfc: don't dereference localport before it has been null checked

localport is being dereferenced to assign lport and then immediately
afterwards localport is being sanity checked to see if it is null.  Fix
this by only dereferencing localport until after it has been null
checked.

Detected by CoverityScan, CID#1463038 ("Dereference before null check")

Fixes: 3a8cefbfc5ee ("scsi: lpfc: Beef up stat counters for debug")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_attr.c