]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx5e: Avoid using the ipv6 stub in the TC offload neigh update path
authorOr Gerlitz <ogerlitz@mellanox.com>
Tue, 13 Mar 2018 19:43:43 +0000 (21:43 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Mon, 26 Mar 2018 20:58:48 +0000 (13:58 -0700)
commita6ae5451bde2eb7c1f8484afb895360ea33e2843
tree50f6c81a73a24b91a913e72db8145e046afe8cf9
parentf685dbf8ed3d71628642a53fd2322ec6b5c33f23
net/mlx5e: Avoid using the ipv6 stub in the TC offload neigh update path

Currently we use the global ipv6_stub var to access the ipv6 global
nd table. This practice gets us to troubles when the stub is only partially
set e.g when ipv6 is loaded under the disabled policy. In this case, as of commit
a1f1d537e803 ("ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument")
the stub is not null, but stub->nd_tbl is and we crash.

As we can access the ipv6 nd_tbl directly, the fix is just to avoid the
reference through the stub. There is one place in the code where we
issue ipv6 route lookup and keep doing it through the stub, but that
mentioned commit makes sure we get -EAFNOSUPPORT from the stack.

Fixes: ccf500f6d873 ("net/mlx5e: Add support to neighbour update flow")
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Aviv Heller <avivh@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c