]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Put the downclock_mode check back into can_enable_drrs()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 15 Mar 2022 13:27:44 +0000 (15:27 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 16 Mar 2022 11:12:05 +0000 (13:12 +0200)
commita616e9ea0e698d69b4613b5c93e09e2077243ee5
tree5f61eb49544401b5fc4a7b8500aa903383405247
parent646131b8913c866a7f2fdfe5b4e71de7c39db6dc
drm/i915: Put the downclock_mode check back into can_enable_drrs()

With static DRRS the user might ask for the lowest possible refresh
rate of the panel, in which case we're not going to find a suitable
downclock mode for it and we should not try to enable seamless DRRS.
This will in fact oops.

We used to check for the presence of the downclock mode here, but
that got removed in commit b7e795a1135b ("drm/i915: Introduce
intel_panel_drrs_type()") as redundant (which it was at the time).
But we do need the check again now that static DRRS is a thing.

I must have not re-tested static DRRS fully after introducing
intel_panel_drrs_type() :/

Fixes: 95f90b797533 ("drm/i915: Implement static DRRS")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220315132752.11849-2-ville.syrjala@linux.intel.com
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
drivers/gpu/drm/i915/display/intel_drrs.c