]> git.baikalelectronics.ru Git - kernel.git/commit
drm/msm: uninitialized variable in msm_gem_import()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 13 Oct 2021 08:13:15 +0000 (11:13 +0300)
committerRob Clark <robdclark@chromium.org>
Fri, 15 Oct 2021 23:58:14 +0000 (16:58 -0700)
commita5e651f27601e19547f23c1e73b1806a440acfe2
treeacd4fa45d8e8064ed12b1a3f84e211985a2fe9f3
parent8b92910ed9caf10a5eb3adeed3057689bce64858
drm/msm: uninitialized variable in msm_gem_import()

The msm_gem_new_impl() function cleans up after itself so there is no
need to call drm_gem_object_put().  Conceptually, it does not make sense
to call a kref_put() function until after the reference counting has
been initialized which happens immediately after this call in the
drm_gem_(private_)object_init() functions.

In the msm_gem_import() function the "obj" pointer is uninitialized, so
it will lead to a crash.

Fixes: 67d6b37fffe6 ("drm/msm: prime support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211013081315.GG6010@kili
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/msm_gem.c