]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: tas2770: Fix set_tdm_slot in case of single slot
authorMartin Povišer <povik+lin@cutebit.org>
Thu, 27 Oct 2022 09:57:58 +0000 (11:57 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 31 Oct 2022 13:19:59 +0000 (13:19 +0000)
commita56f9afa3c834105f0b045af9a431ac3b178465c
treeb308145a97db4fd46bf073b0608cf03953019ed3
parent58691dcb9215bb700279901c5218a2012591b5df
ASoC: tas2770: Fix set_tdm_slot in case of single slot

There's a special branch in the set_tdm_slot op for the case of nslots
being 1, but:

 (1) That branch can never work (there's a check for tx_mask being
     non-zero, later there's another check for it *being* zero; one or
     the other always throws -EINVAL).

 (2) The intention of the branch seems to be what the general other
     branch reduces to in case of nslots being 1.

For those reasons remove the 'nslots being 1' special case.

Fixes: 8c41a7cb5897 ("tas2770: add tas2770 smart PA kernel driver")
Suggested-by: Jos Dehaes <jos.dehaes@gmail.com>
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20221027095800.16094-1-povik+lin@cutebit.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2770.c