]> git.baikalelectronics.ru Git - kernel.git/commit
rcu/nocb: Trigger self-IPI on late deferred wake up before user resume
authorFrederic Weisbecker <frederic@kernel.org>
Sun, 31 Jan 2021 23:05:46 +0000 (00:05 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 17 Feb 2021 13:12:43 +0000 (14:12 +0100)
commita4e0b83cc2107f83efb1c599427fd88476b35c63
tree13b2de7448909cfade6100836b4cd561ecded298
parentce2ce7855adb190042143536b4aae41d9de9f906
rcu/nocb: Trigger self-IPI on late deferred wake up before user resume

Entering RCU idle mode may cause a deferred wake up of an RCU NOCB_GP
kthread (rcuog) to be serviced.

Unfortunately the call to rcu_user_enter() is already past the last
rescheduling opportunity before we resume to userspace or to guest mode.
We may escape there with the woken task ignored.

The ultimate resort to fix every callsites is to trigger a self-IPI
(nohz_full depends on arch to implement arch_irq_work_raise()) that will
trigger a reschedule on IRQ tail or guest exit.

Eventually every site that want a saner treatment will need to carefully
place a call to rcu_nocb_flush_deferred_wakeup() before the last explicit
need_resched() check upon resume.

Fixes: 188be2a8e26e (rcu: Break call_rcu() deadlock involving scheduler and perf)
Reported-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/20210131230548.32970-4-frederic@kernel.org
kernel/rcu/tree.c
kernel/rcu/tree.h
kernel/rcu/tree_plugin.h