]> git.baikalelectronics.ru Git - kernel.git/commit
usb: gadget: f_fs: Ensure ep0req is dequeued before free_request
authorUdipto Goswami <quic_ugoswami@quicinc.com>
Thu, 15 Dec 2022 05:29:06 +0000 (10:59 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:34:21 +0000 (08:34 +0100)
commita4a41ecbec2c23b07f88cfa7d753ce176c08b70f
treec81ec649a98014d40177d1bd0945c0e4fdbf1c7e
parenta1f0f4b99cb3d688d1d780f36076a5fb1cafc024
usb: gadget: f_fs: Ensure ep0req is dequeued before free_request

[ Upstream commit 759d016383d1ca7aed2aa2d4827b7c268e00330c ]

As per the documentation, function usb_ep_free_request guarantees
the request will not be queued or no longer be re-queued (or
otherwise used). However, with the current implementation it
doesn't make sure that the request in ep0 isn't reused.

Fix this by dequeuing the ep0req on functionfs_unbind before
freeing the request to align with the definition.

Fixes: 5dc5692bef4b ("USB: f_fs: the FunctionFS driver")
Signed-off-by: Udipto Goswami <quic_ugoswami@quicinc.com>
Tested-by: Krishna Kurapati <quic_kriskura@quicinc.com>
Link: https://lore.kernel.org/r/20221215052906.8993-3-quic_ugoswami@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/function/f_fs.c