]> git.baikalelectronics.ru Git - kernel.git/commit
V4L/DVB (7285): em28xx: Correct use of ! and &
authorJulia Lawall <julia@diku.dk>
Tue, 26 Feb 2008 23:43:56 +0000 (20:43 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Thu, 20 Mar 2008 15:39:00 +0000 (12:39 -0300)
commita473b9a4c401eeff76eda91a656c6200fd371727
tree2fc57398ce93afef0e19c2a6dcfba12d719c6f8c
parent858a132ac2655188a9fa63693d4426264053cbf9
V4L/DVB (7285): em28xx: Correct use of ! and &

In commit fbb1ccd43b0dfa2ef851295f09c104022e4e2c88, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/em28xx/em28xx-core.c