]> git.baikalelectronics.ru Git - kernel.git/commit
soc: qcom: wcnss_ctrl: Avoid string overflow
authorNiklas Cassel <niklas.cassel@linaro.org>
Wed, 29 Aug 2018 07:57:21 +0000 (09:57 +0200)
committerAndy Gross <andy.gross@linaro.org>
Thu, 13 Sep 2018 21:11:36 +0000 (16:11 -0500)
commita43b4cdeb6713b98a5be0c39ac5b87b2ac3a947a
tree343f7788d4494f31c60b103cbc0d91cce7d03da1
parent59acbe11d6ad4acc1fa27138960ccae4d316d147
soc: qcom: wcnss_ctrl: Avoid string overflow

'chinfo.name' is used as a NUL-terminated string, but using strncpy() with
the length equal to the buffer size may result in lack of the termination:

drivers//soc/qcom/wcnss_ctrl.c: In function 'qcom_wcnss_open_channel':
drivers//soc/qcom/wcnss_ctrl.c:284:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
  strncpy(chinfo.name, name, sizeof(chinfo.name));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This changes it to use the safer strscpy() instead.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
drivers/soc/qcom/wcnss_ctrl.c