]> git.baikalelectronics.ru Git - kernel.git/commit
mlxsw: core: Add missing rollback in error path
authorIdo Schimmel <idosch@mellanox.com>
Mon, 28 Nov 2016 17:01:25 +0000 (18:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Nov 2016 01:48:51 +0000 (20:48 -0500)
commita439901125f1e6c42d147725b159bc24d42788b8
treed6e84fa7f256986cecafc3fa5a1c891ca195c72d
parentfa862e8897c0eccb99c51d42cfe4e04eb780776a
mlxsw: core: Add missing rollback in error path

Without this rollback, the thermal zone is still registered during the
error path, whereas its private data is freed upon the destruction of
the underlying bus device due to the use of devm_kzalloc(). This results
in use after free.

Fix this by calling mlxsw_thermal_fini() from the appropriate place in
the error path.

Fixes: c3504e62812b ("mlxsw: core: Implement thermal zone")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core.c