]> git.baikalelectronics.ru Git - kernel.git/commit
drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier
authorThomas Gleixner <tglx@linutronix.de>
Tue, 19 Mar 2019 14:51:56 +0000 (15:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Apr 2019 09:16:31 +0000 (11:16 +0200)
commita42c1d6639ddca9505e5a88b5b84bb10aaff87db
tree1c2eb813c67c42290c32542cc92380a38f00ea1e
parent8cd591efcb9c9bf4ee95c7023c353f24cb8af5ff
drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier

spdxcheck.py complains:

 drivers/power/supply/goldfish_battery.c: 1:28 Invalid License ID: GPL

which is correct because GPL is not a valid identifier. Of course this
could have been caught by checkpatch.pl _before_ submitting or merging the
patch.

 WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/...
 #19: FILE: drivers/power/supply/goldfish_battery.c:1:
 +// SPDX-License-Identifier: GPL

Which is absolutely hillarious as the commit introducing this wreckage says
in the changelog:

  There was a checkpatch complain:

    "Missing or malformed SPDX-License-Identifier tag".

Oh well. Replacing a checkpatch warning by a different checkpatch warning
is a really useful exercise.

Use the proper GPL-2.0 identifier which is what the boiler plate in the
file had originally.

Fixes: 582cf1e4adcc ("drivers: power: supply: goldfish_battery: Put an SPDX tag")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/supply/goldfish_battery.c