]> git.baikalelectronics.ru Git - kernel.git/commit
lib: use PFN_PHYS() in devmem_is_allowed()
authorLiang Wang <wangliang101@huawei.com>
Fri, 13 Aug 2021 23:54:45 +0000 (16:54 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 14 Aug 2021 00:09:32 +0000 (14:09 -1000)
commita3f301786d8c9eaa08a31e884a49abdc6cc9a37c
treed7c0a4ce894d98ef3aff49ac6ef6c305bda958a1
parentfc3ccb5ca3e1abbecda669e408ddfed0a55c777e
lib: use PFN_PHYS() in devmem_is_allowed()

The physical address may exceed 32 bits on 32-bit systems with more than
32 bits of physcial address.  Use PFN_PHYS() in devmem_is_allowed(), or
the physical address may overflow and be truncated.

We found this bug when mapping a high addresses through devmem tool,
when CONFIG_STRICT_DEVMEM is enabled on the ARM with ARM_LPAE and devmem
is used to map a high address that is not in the iomem address range, an
unexpected error indicating no permission is returned.

This bug was initially introduced from v2.6.37, and the function was
moved to lib in v5.11.

Link: https://lkml.kernel.org/r/20210731025057.78825-1-wangliang101@huawei.com
Fixes: dc33085d6c82 ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Fixes: 3e7396b0a1e8 ("lib: Add a generic version of devmem_is_allowed()")
Signed-off-by: Liang Wang <wangliang101@huawei.com>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Palmer Dabbelt <palmerdabbelt@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Liang Wang <wangliang101@huawei.com>
Cc: Xiaoming Ni <nixiaoming@huawei.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [2.6.37+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/devmem_is_allowed.c