]> git.baikalelectronics.ru Git - kernel.git/commit
spi: uniphier: fix reference count leak in uniphier_spi_probe()
authorXin Xiong <xiongx18@fudan.edu.cn>
Tue, 25 Jan 2022 10:12:15 +0000 (18:12 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 26 Jan 2022 15:52:05 +0000 (15:52 +0000)
commita3de072a22ad5b379f367e62ccaa3803bdaa1c5b
treed071a363b9427eceeb68690d79e67ed1ab78bb64
parent9982a70da7c35d1acabdba9882d99cf9af1f19ce
spi: uniphier: fix reference count leak in uniphier_spi_probe()

The issue happens in several error paths in uniphier_spi_probe().
When either dma_get_slave_caps() or devm_spi_register_master() returns
an error code, the function forgets to decrease the refcount of both
`dma_rx` and `dma_tx` objects, which may lead to refcount leaks.

Fix it by decrementing the reference count of specific objects in
those error paths.

Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Fixes: ad7f7899a9e8 ("spi: uniphier: Add DMA transfer mode support")
Link: https://lore.kernel.org/r/20220125101214.35677-1-xiongx18@fudan.edu.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-uniphier.c