]> git.baikalelectronics.ru Git - kernel.git/commit
media: uvcvideo: Fix memory leak in uvc_gpio_parse
authorJosé Expósito <jose.exposito89@gmail.com>
Sat, 8 Jan 2022 17:04:39 +0000 (18:04 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 30 Aug 2022 14:04:19 +0000 (16:04 +0200)
commita3afa3187da6d1f72102ded0c0f519c65ba9e625
tree049209cd3042a233d2284997c74747d6bdf6f888
parent1596cfc2e8943d34e204eb68579c61f52df5d0d0
media: uvcvideo: Fix memory leak in uvc_gpio_parse

Previously the unit buffer was allocated before checking the IRQ for
privacy GPIO. In case of error, the unit buffer was leaked.

Allocate the unit buffer after the IRQ to avoid it.

Addresses-Coverity-ID: 1474639 ("Resource leak")

Fixes: 07ce5c5edb9c ("media: uvcvideo: Implement UVC_EXT_GPIO_UNIT")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/usb/uvc/uvc_driver.c