]> git.baikalelectronics.ru Git - kernel.git/commit
net: ipa: fix atomic update in ipa_endpoint_replenish()
authorAlex Elder <elder@linaro.org>
Wed, 12 Jan 2022 13:30:10 +0000 (07:30 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Jan 2022 14:39:53 +0000 (14:39 +0000)
commita3485c5fc06c851c012ecde80d2ed380e957c17a
tree93dca312e33469dc18862387d22d063dbeeaa3d6
parent878a0fe7817394c5b583837f9470c332d0ea3f14
net: ipa: fix atomic update in ipa_endpoint_replenish()

In ipa_endpoint_replenish(), if an error occurs when attempting to
replenish a receive buffer, we just quit and try again later.  In
that case we increment the backlog count to reflect that the attempt
was unsuccessful.  Then, if the add_one flag was true we increment
the backlog again.

This second increment is not included in the backlog local variable
though, and its value determines whether delayed work should be
scheduled.  This is a bug.

Fix this by determining whether 1 or 2 should be added to the
backlog before adding it in a atomic_add_return() call.

Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Fixes: e66f933cb5e18 ("soc: qcom: ipa: IPA endpoints")
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipa/ipa_endpoint.c