]> git.baikalelectronics.ru Git - kernel.git/commit
rpmsg: glink: initialize ret to zero to ensure error status check is correct
authorColin Ian King <colin.king@canonical.com>
Sun, 3 Sep 2017 13:06:01 +0000 (14:06 +0100)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 4 Sep 2017 17:52:30 +0000 (10:52 -0700)
commita330865e4d4b76756ef0637b2df90cdb77889170
tree90d5f0f36172a3922136152f440952e014b1e90b
parent2da722827c175a5dc58df09b0240775a54ff7230
rpmsg: glink: initialize ret to zero to ensure error status check is correct

The new switch cases for RPM_CMD_RX_DONE, RPM_CMD_RX_DONE_W_REUSE,
RPM_CMD_RX_INTENT_REQ_ACK, RPM_CMD_INTENT and RPM_CMD_RX_INTENT_REQ from
4 recent commits are not setting ret and so a later non-zero check on ret
is testing on a garbage value in ret. Fix this by initializing ret to zero.

Detected by CoverityScan CID#1455249 ("Uninitialized scalar variable")

Fixes: 23d28d6b00c9 ("rpmsg: glink: Add support for TX intents)
Fixes: e4d845bba4c1 ("glink: Receive and store the remote intent buffers")
Fixes: c4153f7a7c22 ("rpmsg: glink: Request for intents when unavailable")
Fixes: d69a6aa19fc5 ("rpmsg: glink: Handle remote rx done command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/rpmsg/qcom_glink_native.c