]> git.baikalelectronics.ru Git - kernel.git/commit
erofs: fix erofs_get_meta_page locking due to a cleanup
authorGao Xiang <gaoxiang25@huawei.com>
Sat, 21 Sep 2019 18:43:55 +0000 (02:43 +0800)
committerGao Xiang <gaoxiang25@huawei.com>
Mon, 30 Sep 2019 20:54:33 +0000 (04:54 +0800)
commita3165bbbc7f8ab6d7ba8ffac48f5a8f082758c89
treeb5dede17c84b402f3fde651885ddd89705a41cc8
parent2205a3ad643d51c39051d53b1d3334e02556bb1f
erofs: fix erofs_get_meta_page locking due to a cleanup

After doing more drop_caches stress test on
our products, I found the mistake introduced by
a very recent cleanup [1].

The current rule is that "erofs_get_meta_page"
should be returned with page locked (although
it's mostly unnecessary for read-only fs after
pages are PG_uptodate), but a fix should be
done for this.

[1] https://lore.kernel.org/r/20190904020912.63925-26-gaoxiang25@huawei.com
Fixes: 52772e138f35 ("erofs: use read_cache_page_gfp for erofs_get_meta_page")
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Link: https://lore.kernel.org/r/20190921184355.149928-1-gaoxiang25@huawei.com
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
fs/erofs/data.c