]> git.baikalelectronics.ru Git - kernel.git/commit
ice: Fix inability to set channels when down
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Sat, 16 May 2020 00:55:00 +0000 (17:55 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Sun, 31 May 2020 10:49:00 +0000 (03:49 -0700)
commita301048db3068cc7988ae37b767cde3c1eae807b
treebcaa683b58697b6ea738b9dea065b050cb966e29
parente70977605c735874bb40a5cff87fe5bba4458c4f
ice: Fix inability to set channels when down

Currently the driver prevents a user from doing
modprobe ice
ethtool -L eth0 combined 5
ip link set eth0 up

The ethtool command fails, because the driver is checking to see if the
interface is down before allowing the get_channels to proceed (even for
a set_channels).

Remove this check and allow the user to configure the interface
before bringing it up, which is a much better usability case.

Fixes: b13396ff6434 ("ice: Implement ethtool ops for channels")
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_ethtool.c