]> git.baikalelectronics.ru Git - kernel.git/commit
dmaengine: sprd: Fix potential NULL dereference in sprd_dma_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 7 May 2018 01:40:34 +0000 (01:40 +0000)
committerVinod Koul <vkoul@kernel.org>
Mon, 7 May 2018 08:01:32 +0000 (13:31 +0530)
commita2f9d62ff43d343ffbb6bf04643eb9906f1f4dea
treee783ee2f7cd1c5a4617e339c195813da3ecb1595
parentee2e68c9f891ff1e0c016ae7a520898322d25f0b
dmaengine: sprd: Fix potential NULL dereference in sprd_dma_probe()

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap_nocache(e1, res->start, e2);

Fixes: d83b8b034b49 ("dmaengine: sprd: Add Spreadtrum DMA driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sprd-dma.c