]> git.baikalelectronics.ru Git - kernel.git/commit
firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT
authorSudeep Holla <sudeep.holla@arm.com>
Mon, 11 Nov 2019 16:25:22 +0000 (16:25 +0000)
committerSudeep Holla <sudeep.holla@arm.com>
Thu, 14 Nov 2019 11:13:50 +0000 (11:13 +0000)
commita2c4570b341d3f21387e20a14263672e5644033e
tree6da77533df70498d664575db08cb179f2ac8afe3
parentf5c4776cd5b591eea4e9be9f421e34f61b98ebb2
firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT

The logic to ring the scmi performance fastchannel ignores the
value read from the doorbell register in case of !CONFIG_64BIT.
This bug also shows up as warning with '-Wunused-but-set-variable' gcc
flag:

drivers/firmware/arm_scmi/perf.c: In function scmi_perf_fc_ring_db:
drivers/firmware/arm_scmi/perf.c:323:7: warning: variable val set but
not used [-Wunused-but-set-variable]

Fix the same by aligning the logic with CONFIG_64BIT as used in the
macro SCMI_PERF_FC_RING_DB().

Fixes: 078b25f869f5 ("firmware: arm_scmi: Make use SCMI v2.0 fastchannel for performance protocol")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reported-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/perf.c