]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amdgpu: Fix undue fallthroughs in golden registers initialization
authorJean Delvare <jdelvare@suse.de>
Sun, 30 Jul 2017 08:18:25 +0000 (10:18 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 15 Aug 2017 18:46:05 +0000 (14:46 -0400)
commita2c21a29654a19e6ea1e43ab2f8b46bbbb34de87
treec378b4efdb32d0e92e9620a6af521e7832e1e27e
parent815048ee51589760d6bc0317d9f09c3976399ef4
drm/amdgpu: Fix undue fallthroughs in golden registers initialization

As I was staring at the si_init_golden_registers code, I noticed that
the Pitcairn initialization silently falls through the Cape Verde
initialization, and the Oland initialization falls through the Hainan
initialization. However there is no comment stating that this is
intentional, and the radeon driver doesn't have any such fallthrough,
so I suspect this is not supposed to happen.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: dcfd4a508336 ("drm/amdgpu: add si implementation v10")
Cc: Ken Wang <Qingqing.Wang@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Marek Olšák" <maraeo@gmail.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Flora Cui <Flora.Cui@amd.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/si.c