]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: firewire-tascam: off by one in handle_midi_tx()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 15 Oct 2015 18:17:11 +0000 (21:17 +0300)
committerTakashi Iwai <tiwai@suse.de>
Sat, 17 Oct 2015 10:06:28 +0000 (12:06 +0200)
commita2b46b6c7ca1ae118821f3c4418ec3e036a7f3a8
tree6cef9c43b73c61a3d182db8df2880a812f1abf85
parent338cf2c889e6ec1dade17bfb20d592235fbc1ff4
ALSA: firewire-tascam: off by one in handle_midi_tx()

My static checker complains because tscm->spec->midi_capture_ports is
either 2 or 4 but the tscm->tx_midi_substreams[] array has 4 elements so
this is possibly off by one.  I have looked at the code and I think it
should be >= instead of > as well.

Fixes: 298b289abd79 ('ALSA: firewire-tascam: add support for incoming MIDI messages by asynchronous transaction')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/tascam/tascam-transaction.c