]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: target: fix SendTargets=All string compares
authorDavid Disseldorp <ddiss@suse.de>
Thu, 12 Sep 2019 09:55:46 +0000 (11:55 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 23 Oct 2019 02:14:25 +0000 (22:14 -0400)
commita29e0d29fbc8af379b447725ac1ece4939a5fc1a
tree15c07bdc2c2fab6f92497fddfee18673719fbfd6
parent8bd08cd24547409daf4b57a818abf7ce238dc9d2
scsi: target: fix SendTargets=All string compares

strncmp is currently used for "SendTargets" key and "All" value matching
without checking for trailing garbage. This means that Text request PDUs
with garbage such as "SendTargetsPlease=All" and "SendTargets=Alle" are
processed successfully as if they were "SendTargets=All" requests.

Reviewed-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Link: https://lore.kernel.org/r/20190912095547.22427-3-ddiss@suse.de
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/iscsi/iscsi_target.c