]> git.baikalelectronics.ru Git - kernel.git/commit
remoteproc: Fix IDR initialisation in rproc_alloc()
authorAlex Elder <elder@linaro.org>
Wed, 15 Apr 2020 20:48:52 +0000 (14:48 -0600)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 20 Apr 2020 05:23:00 +0000 (22:23 -0700)
commita242fc556b06b7f08736a2a8b7788fafffc36cb6
tree57bc7b927194cc232d8bd7b1bfe07ea4deedd203
parent9a4a0aba1698537d7d4f16ef6a708948555e2cf1
remoteproc: Fix IDR initialisation in rproc_alloc()

If ida_simple_get() returns an error when called in rproc_alloc(),
put_device() is called to clean things up.  By this time the rproc
device type has been assigned, with rproc_type_release() as the
release function.

The first thing rproc_type_release() does is call:
    idr_destroy(&rproc->notifyids);

But at the time the ida_simple_get() call is made, the notifyids
field in the remoteproc structure has not been initialized.

I'm not actually sure this case causes an observable problem, but
it's incorrect.  Fix this by initializing the notifyids field before
calling ida_simple_get() in rproc_alloc().

Fixes: 49b4eb88a20c ("remoteproc: maintain a generic child device for each rproc")
Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Suman Anna <s-anna@ti.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20200415204858.2448-2-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/remoteproc_core.c