]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: bcm_sf2: Do not configure PHYLINK on CPU port
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 22 Aug 2019 00:07:46 +0000 (17:07 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Aug 2019 03:35:29 +0000 (20:35 -0700)
commita1ed5b3ca2912282a5cbae8aed70895a356eb08e
tree9a33e152248e702fb8a7286eeb8657c69023c74a
parentd9f92fe4da3059dc1da4eae5a6ee67cd43289d6a
net: dsa: bcm_sf2: Do not configure PHYLINK on CPU port

The SF2 binding does not specify that the CPU port should have
properties mandatory for successfully instantiating a PHYLINK object. As
such, there will be missing properties (including fixed-link) and when
attempting to validate and later configure link modes, we will have an
incorrect set of parameters (interface, speed, duplex).

Simply prevent the CPU port from being configured through PHYLINK since
bcm_sf2_imp_setup() takes care of that already.

Fixes: 44df520dc0bf ("net: dsa: Use PHYLINK for the CPU/DSA ports")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/bcm_sf2.c