]> git.baikalelectronics.ru Git - kernel.git/commit
of/platform: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 22 Oct 2015 09:02:49 +0000 (11:02 +0200)
committerRob Herring <robh@kernel.org>
Thu, 22 Oct 2015 14:26:44 +0000 (09:26 -0500)
commita12a2b097fff83a59b9cbb807d72492e64446505
tree3b46cf115cb65a5aeaddaf30393f499c69886e44
parent0ee38618b8761c898faa149d3bf41f1a1d439927
of/platform: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression root,e;
@@

 for_each_child_of_node(root,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/platform.c