]> git.baikalelectronics.ru Git - kernel.git/commit
module: Clean up ro/nx after early module load failures
authorAndy Lutomirski <luto@amacapital.net>
Fri, 15 Aug 2014 18:43:37 +0000 (04:13 +0930)
committerRusty Russell <rusty@rustcorp.com.au>
Fri, 15 Aug 2014 19:17:00 +0000 (04:47 +0930)
commita10b7a14f4a64e7219f68d2bb625397c22cabcc9
tree9956535bca61a8d71cf3d6f94c96399e434be195
parentcb3122d99bfbf9182b3f362039db40b94b45f3cf
module: Clean up ro/nx after early module load failures

The commit

    e264905c7106 module: set nx before marking module MODULE_STATE_COMING.

introduced a regression: if a module fails to parse its arguments or
if mod_sysfs_setup fails, then the module's memory will be freed
while still read-only.  Anything that reuses that memory will crash
as soon as it tries to write to it.

Cc: stable@vger.kernel.org # v3.16
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
kernel/module.c