]> git.baikalelectronics.ru Git - kernel.git/commit
drm/display: fix possible null-pointer dereference in dcn10_set_clock()
authorTuo Li <islituo@gmail.com>
Wed, 11 Aug 2021 04:07:03 +0000 (21:07 -0700)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 11 Aug 2021 21:19:54 +0000 (17:19 -0400)
commita03b1b86b20166eab00434f6bb15b13560b64f19
tree45fc9c6d8f50ef91e8e6e99fee26d3dd017b63ee
parent0ecc66089cb87bc59244477047a6a2b71a3cb5ed
drm/display: fix possible null-pointer dereference in dcn10_set_clock()

The variable dc->clk_mgr is checked in:
  if (dc->clk_mgr && dc->clk_mgr->funcs->get_clock)

This indicates dc->clk_mgr can be NULL.
However, it is dereferenced in:
    if (!dc->clk_mgr->funcs->get_clock)

To fix this null-pointer dereference, check dc->clk_mgr and the function
pointer dc->clk_mgr->funcs->get_clock earlier, and return if one of them
is NULL.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Tuo Li <islituo@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c