]> git.baikalelectronics.ru Git - kernel.git/commit
WAN: dscc4: Fix warning pointing out a bug.
authorDavid S. Miller <davem@davemloft.net>
Fri, 4 Sep 2009 04:34:39 +0000 (21:34 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 4 Sep 2009 04:34:39 +0000 (21:34 -0700)
commita018c8117183aeb47ebcd78a26d78c88bb0973d2
tree9f9fc4922a60e1018009e65e9f72e7e51fb67fe1
parent80356bb0806275085a0309de427c762fd8ef5daf
WAN: dscc4: Fix warning pointing out a bug.

Noticed by Stephen Rothwell:

Today's linux-next build (x86_64 allmodconfig gcc-4.4.0)
produced this warning:

drivers/net/wan/dscc4.c: In function 'dscc4_rx_skb':
drivers/net/wan/dscc4.c:670: warning: suggest parentheses around comparison in operand of '|'

which actually points out a bug, I think.  It is doing
(x & (y | z)) != y | z
when it probably means
(x & (y | z)) != (y | z)

Introduced by commit 7700e8d04dd790572086480723a07f0a6c80d42a
("WAN: bit and/or confusion").

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/dscc4.c