]> git.baikalelectronics.ru Git - kernel.git/commit
drm/sun4i: tcon-top: Use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 24 Aug 2018 01:05:21 +0000 (20:05 -0500)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Fri, 24 Aug 2018 14:02:10 +0000 (16:02 +0200)
commita000d5d4298056374a0e28c296e2c599fd245fdf
treee96808989a038e2cbb1b35b7b76b4bed96eabae2
parent8a89569d41068612fd43eedea96ed66892c1d51c
drm/sun4i: tcon-top: Use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
int stuff;
        void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This issue was detected with the help of Coccinelle.

Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180824010521.GA25451@embeddedor.com
drivers/gpu/drm/sun4i/sun8i_tcon_top.c