]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: dbg: Don't touch the tlv data
authorTakashi Iwai <tiwai@suse.de>
Tue, 12 Jan 2021 13:24:48 +0000 (14:24 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 14 Jan 2021 16:56:37 +0000 (18:56 +0200)
commit9f338da4c538256a0d5a06f92df421c7e8453fbc
tree027f4e16933f06fb53902f04872abfd84512dc9a
parented09ecb2d689f97ca8e7aa893c3d991fc48ce11f
iwlwifi: dbg: Don't touch the tlv data

The commit b3292c64a22f ("iwlwifi: dbg: add dumping special device
memory") added a termination of name string just to be sure, and this
seems causing a regression, a GPF triggered at firmware loading.
Basically we shouldn't modify the firmware data that may be provided
as read-only.

This patch drops the code that caused the regression and keep the tlv
data as is.

Fixes: b3292c64a22f ("iwlwifi: dbg: add dumping special device memory")
BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1180344
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210733
Cc: stable@vger.kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210112132449.22243-2-tiwai@suse.de
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c