]> git.baikalelectronics.ru Git - kernel.git/commit
wifi: rndis_wlan: Prevent buffer overflow in rndis_query_oid
authorSzymon Heidrich <szymon.heidrich@gmail.com>
Wed, 11 Jan 2023 17:50:31 +0000 (18:50 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Feb 2023 07:34:18 +0000 (08:34 +0100)
commit9f1e40ab6299fa53fd8c3a62adf6f716ed65e60b
tree6a11a542abf6e153bb4c1a51ffd6a57fe7d6cd1c
parent47200ff63c3547c08cdac572f1a28fbb4df2441b
wifi: rndis_wlan: Prevent buffer overflow in rndis_query_oid

[ Upstream commit b870e73a56c4cccbec33224233eaf295839f228c ]

Since resplen and respoffs are signed integers sufficiently
large values of unsigned int len and offset members of RNDIS
response will result in negative values of prior variables.
This may be utilized to bypass implemented security checks
to either extract memory contents by manipulating offset or
overflow the data buffer via memcpy by manipulating both
offset and len.

Additionally assure that sum of resplen and respoffs does not
overflow so buffer boundaries are kept.

Fixes: fcc264202521 ("rndis_wlan: copy only useful data from rndis_command respond")
Signed-off-by: Szymon Heidrich <szymon.heidrich@gmail.com>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230111175031.7049-1-szymon.heidrich@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/rndis_wlan.c