]> git.baikalelectronics.ru Git - kernel.git/commit
bnx2: Add missing memory barrier in bnx2_start_xmit()
authorVlad Zolotarov <vlad@scalemp.com>
Sun, 5 Feb 2012 15:24:39 +0000 (15:24 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Feb 2012 03:42:00 +0000 (22:42 -0500)
commit9e1ac1c90fff167ce423d4ab6478f17ea0927084
tree228947bbd33977940a8262512072528a64cdfa30
parentd7ee594f2f2c1a056a9ddfa2187c857b29dcaa3c
bnx2: Add missing memory barrier in bnx2_start_xmit()

Sync DMA descriptor before hitting the TX mailbox for weak memory model
CPUs.

There has been discussions several years ago about this.  Some believe
that writel() should guarantee ordering.  Others want explicit barriers
if necessary.  Today writel() does not have the ordering guarantee and
many other drivers use explicit barriers.

Signed-off-by: Vlad Zolotarov <vlad@scalemp.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2.c