]> git.baikalelectronics.ru Git - kernel.git/commit
spi: spi-ti-qspi: Fix return value handling of wait_for_completion_timeout
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 11 Apr 2022 11:10:33 +0000 (11:10 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:22:46 +0000 (10:22 +0200)
commit9d6c8e5456fd06682d0ce1ac6b5026600ba37476
treec8ed815e80f7e4c83d34e208a2200a1ce4edb2a3
parent92a1651b80bcb7a7790526502be65eb197e2abf0
spi: spi-ti-qspi: Fix return value handling of wait_for_completion_timeout

[ Upstream commit e3071a90cdef574cd197cbf8bdf9ad17c02aaaf2 ]

wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.

Fixes: 4f118c473276 ("spi: spi-ti-qspi: Add DMA support for QSPI mmap read")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220411111034.24447-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-ti-qspi.c