]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: echoaduio: Drop superfluous volatile modifier
authorTakashi Iwai <tiwai@suse.de>
Mon, 3 Aug 2020 14:39:58 +0000 (16:39 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 11 Aug 2020 12:21:49 +0000 (14:21 +0200)
commit9d51e060144e2ee52555640088a57b9bba4d5467
tree529ced751eeac91fae6e89244d88786e64c1f3bf
parentf45bca4ae015f88cdc43532105d22cb40724fe07
ALSA: echoaduio: Drop superfluous volatile modifier

The dsp_registers field of struct echoaduio has the volatile modifier,
but it's basically superfluous; the field is accessed only for the
base pointer of readl() and writel(), hence marking with __iomem alone
should suffice.  OTOH, having the volatile prefix causes a compile
warning like:
  sound/pci/echoaudio/echoaudio.c:1878:14: warning: passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type [-Wdiscarded-qualifiers]

So it's better to drop this superfluous modifier.

Link: https://lore.kernel.org/r/20200803143958.24324-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/echoaudio/echoaudio.c
sound/pci/echoaudio/echoaudio.h