]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"
authorKees Cook <keescook@chromium.org>
Thu, 10 Aug 2017 04:11:00 +0000 (21:11 -0700)
committerKees Cook <keescook@chromium.org>
Thu, 17 Aug 2017 23:29:19 +0000 (16:29 -0700)
commit9d336a56e462a70fd5dd83804313b6881cf61203
treef3eaa286c2a932e1f348ae3b322eedd9fea9cefa
parent8743cd33b76000b3e3d91c113fde1e536600b888
Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"

This reverts commit c21a403ae0ca2b759710a10810fe84a209e01ccf, with
various conflict clean-ups.

The capability check required too much privilege compared to simple DAC
controls. A system builder was forced to have crash handler processes
run with CAP_SYSLOG which would give it the ability to read (and wipe)
the _current_ dmesg, which is much more access than being given access
only to the historical log stored in pstorefs.

With the prior commit to make the root directory 0750, the files are
protected by default but a system builder can now opt to give access
to a specific group (via chgrp on the pstorefs root directory) without
being forced to also give away CAP_SYSLOG.

Suggested-by: Nick Kralevich <nnk@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
fs/pstore/inode.c
include/linux/syslog.h
kernel/printk/printk.c