]> git.baikalelectronics.ru Git - kernel.git/commit
vmcore: Remove "weak" from function declarations
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 14 Oct 2014 00:59:41 +0000 (18:59 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 22 Oct 2014 22:14:04 +0000 (16:14 -0600)
commit9d1217f65bdfb58ad07cbb60abcafb581999f11b
treecb6d5fc631582ca565a3d6cc59e5bdd84eeabd77
parente90161fe4bed2462dfe0b7e25f879f8a571a7d0f
vmcore: Remove "weak" from function declarations

For the following functions:

  elfcorehdr_alloc()
  elfcorehdr_free()
  elfcorehdr_read()
  elfcorehdr_read_notes()
  remap_oldmem_pfn_range()

fs/proc/vmcore.c provides default definitions explicitly marked "weak".
arch/s390 provides its own definitions intended to override the default
ones, but the "weak" attribute on the declarations applied to the s390
definitions as well, so the linker chose one based on link order (see
abef42debb2e ("PCI: Remove __weak annotation from pcibios_get_phb_of_node
decl")).

Remove the "weak" attribute from the declarations so we always prefer a
non-weak definition over the weak one, independent of link order.

Fixes: fc0161a20a5e ("vmcore: introduce ELF header in new memory feature")
Fixes: 1816da415973 ("vmcore: introduce remap_oldmem_pfn_range()")
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
CC: Michael Holzheu <holzheu@linux.vnet.ibm.com>
include/linux/crash_dump.h