]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl: ralink: Check for null return of devm_kcalloc
authorWilliam Dean <williamsukatube@gmail.com>
Sun, 10 Jul 2022 15:49:22 +0000 (23:49 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 29 Jul 2022 15:25:10 +0000 (17:25 +0200)
commit9ccf5b0a942921300a673545b450ffa2b91a2958
treee31a840c96458a349b51fbfed667a17e32159d7f
parent53d821da4c22897eeb4258691246ca039be1af64
pinctrl: ralink: Check for null return of devm_kcalloc

[ Upstream commit dc3d521def94d25314a9bdfe7dd81e7ad874ec22 ]

Because of the possible failure of the allocation, data->domains might
be NULL pointer and will cause the dereference of the NULL pointer
later.
Therefore, it might be better to check it and directly return -ENOMEM
without releasing data manually if fails, because the comment of the
devm_kmalloc() says "Memory allocated with this function is
automatically freed on driver detach.".

Fixes: 73d07047d7443 ("treewide: devm_kzalloc() -> devm_kcalloc()")
Reported-by: Hacash Robot <hacashRobot@santino.com>
Signed-off-by: William Dean <williamsukatube@gmail.com>
Link: https://lore.kernel.org/r/20220710154922.2610876-1-williamsukatube@163.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/ralink/pinctrl-ralink.c